From c05670c2885c80eeeaeaf19d25aa0e4b111cd5be Mon Sep 17 00:00:00 2001 From: Romain Failliot Date: Sat, 20 Jun 2020 19:01:56 -0400 Subject: [PATCH 1/4] Fix icons directory for gtk-update-icon-cache --- install.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.py b/install.py index 1a55ff3..46ce777 100755 --- a/install.py +++ b/install.py @@ -264,7 +264,7 @@ if not files_only: print(f'Performing post {stage} tasks.') cmds = [ [ 'update-desktop-database' ], - [ 'gtk-update-icon-cache', os.path.join(destdir, os.path.join(prefix, 'icons/hicolor')[1:]) ] ] + [ 'gtk-update-icon-cache', os.path.join(destdir, os.path.join(prefix, 'share/icons/hicolor')[1:]) ] ] if install: cmds.append([ 'scrollkeeper-update', '-q', '-o', os.path.join(destdir, os.path.join(prefix, 'share/omf/diffuse')[1:]) ]) else: From 236a8dbcd1e2e7340d10e4af7a499c6ff3f2be3a Mon Sep 17 00:00:00 2001 From: Romain Failliot Date: Sat, 20 Jun 2020 19:02:48 -0400 Subject: [PATCH 2/4] Fix missing directories to remove when uninstalling --- install.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/install.py b/install.py index 46ce777..fe5deca 100755 --- a/install.py +++ b/install.py @@ -252,7 +252,17 @@ processTranslations(install, os.path.join(destdir, prefix[1:])) if not install: # remove directories we own - for s in 'share/omf/diffuse', 'share/gnome/help/diffuse/C', 'share/gnome/help/diffuse/ru', 'share/gnome/help/diffuse', 'share/diffuse/syntax', 'share/diffuse': + dirs_to_remove = [ + 'share/omf/diffuse', + 'share/gnome/help/diffuse/C', + 'share/gnome/help/diffuse/cs', + 'share/gnome/help/diffuse/it', + 'share/gnome/help/diffuse/ru', + 'share/gnome/help/diffuse', + 'share/diffuse/syntax', + 'share/diffuse' + ] + for s in dirs_to_remove: d = os.path.join(destdir, os.path.join(prefix, s)[1:]) try: os.rmdir(d) From c8ea1bf5db64f11467340981bd7417247f6c9678 Mon Sep 17 00:00:00 2001 From: Romain Failliot Date: Sat, 20 Jun 2020 19:03:38 -0400 Subject: [PATCH 3/4] Print message when removing files --- install.py | 1 + 1 file changed, 1 insertion(+) diff --git a/install.py b/install.py index fe5deca..f3928f5 100755 --- a/install.py +++ b/install.py @@ -151,6 +151,7 @@ def processFiles(install, dst, src, template): os.chmod(d, 0o755) else: # remove file + print(f'Removing {d}') removeFile(d) # compile .po files and install From 5030bb21266f8bac20f72ae7ea408965be9ab841 Mon Sep 17 00:00:00 2001 From: Romain Failliot Date: Sat, 20 Jun 2020 19:08:23 -0400 Subject: [PATCH 4/4] Update CHANGELOG.md --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 36a1f45..636e3d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - added a preference and command line option to specify the version control system search order - added .editorconfig file - added .gitignore file +- added message when removing files during uninstallation ### Changed - convert to Python 3 @@ -23,6 +24,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - improve Spanish translation - convert translation README to MarkDown +### Fixed +- fixed wrong icons directory for gtk-update-icon-cache +- fixed missing directories when uninstalling + ## [0.4.8] - 2014-07-18 ### Added - updated use of gtk.SpinButton and gtk.Entry to avoid quirks seen on some platforms